August 2013 - Release-team - mailman3.cels.anl.gov

Re: [Release-team] bool is now a reserved word
by Michael Sneddon 04 Aug '13

04 Aug '13

There's not too many, so I think we should change it ourselves if roll out this change. But... I'm still not sure the bool type is ready to be rolled out. It works in Perl, but I'm not sure that all client server language combinations will work. I know for sure we will need some changes to the python code, if Gavin hasn't made them this weekend yet. The encoding to bool type in json I think is also handled differently in Perl and java right now. It would have been nice to use a more formal process for rolling out and testing these types of core changes. I'm about to get on a plane so I'll be offline for most of the day, but I'll try to test and see what issues come up en route. On Aug 4, 2013 10:19 AM, "Nomi Harris" <nlharris(a)lbl.gov> wrote: > Tom wrote: > > Check your type spec for bool typedefs. Remove those. > > > > typedef int bool > > > > bool is now a reserved word > > I found "typedef int bool" in several services: > > grep "typedef int bool" */*spec */*/*spec > KBaseFBAModeling/fbaModelServices.spec: typedef int bool; > experiment/experiment.spec: typedef int boolean; > probabilistic_annotation/ProbabilisticAnnotation.spec: typedef int bool; > prom_service/PROM.spec: typedef int bool; > structured_assertions/SAL.spec: typedef int boolean; > trees/Tree.spec: typedef int boolean; > workspace_deluxe/workspace.spec: typedef int boolean; > kb_seed/lib/CDMI-API.spec: typedef int boolean; > > > Should we tell the developers or just fix it ourselves? (I can do it.) > > Nomi > _______________________________________________ > Release-team mailing list > Release-team(a)lists.kbase.us > https://lists.kbase.us/mailman/listinfo/release-team >

1 0

bool is now a reserved word
by Nomi Harris 04 Aug '13

04 Aug '13

Tom wrote: > Check your type spec for bool typedefs. Remove those. > > typedef int bool > > bool is now a reserved word I found "typedef int bool" in several services: grep "typedef int bool" */*spec */*/*spec KBaseFBAModeling/fbaModelServices.spec: typedef int bool; experiment/experiment.spec: typedef int boolean; probabilistic_annotation/ProbabilisticAnnotation.spec: typedef int bool; prom_service/PROM.spec: typedef int bool; structured_assertions/SAL.spec: typedef int boolean; trees/Tree.spec: typedef int boolean; workspace_deluxe/workspace.spec: typedef int boolean; kb_seed/lib/CDMI-API.spec: typedef int boolean; Should we tell the developers or just fix it ourselves? (I can do it.) Nomi

1 0

Ready to deploy probabilistic annotation service
by Mundy, Michael B. (Mike) 02 Aug '13

02 Aug '13

We are ready to deploy the probabilistic annotation service in the build next week. Note that the service is using Shock which has a version dependency on the requests python package (see https://atlassian.kbase.us/browse/KBASE-215) Mike Mundy | Senior Analyst Programmer | Bioinformatics Systems Unit | 507-266-7232 | mundy.michael(a)mayo.edu<mailto:[email protected]> Mayo Clinic | 200 First Street SW | Rochester, MN 55905 | mayoclinic.org<http://www.mayoclinic.org>

1 0

Re: [Release-team] Testing expectations for next week
by Land, Miriam L. 02 Aug '13

02 Aug '13

Yup, last bullet item. Anything else? Miriam On 8/2/13 11:22 AM, "Thomas Brettin" <brettin(a)mcs.anl.gov> wrote: >There will be a test for updated RELEASE_NOTES > >Tom > > >On Aug 2, 2013, at 10:15 AM, "Land, Miriam L." <landml(a)ornl.gov> wrote: > >> Release Team, >> >> I want to send out a set of expectations we have of module owners for >>the build. Anything you would like to add? >> >> For next week's build, testing will cover: >> >> * The testing team will go the the test VM for your module and will >>run 'make test' on your module (initial test) >> * If there are no tests in 'make test', this could cause the >>module to fail testing >> * The testing team will attempt to find at least one test for every >>method in your module (completeness test) >> * A dialog will determine if incomplete tests are a warning or a >>failure. Tom has final say. >> * Black box testing will be done on any modules that are new with >>this build >> * There will be a test for the existence of a COMMANDS file? >> * Can a list of commands be extracted from the COMMANDS file >> * Does each command accept ‹help as an input and return >>information that can be included in the user manual >> * Is there a release notes file? >> * Is the update date on the release notes as current as the module? >> >> Miriam >> _______________________________________________ >> Release-team mailing list >> Release-team(a)lists.kbase.us >> https://lists.kbase.us/mailman/listinfo/release-team >

1 0

Re: [Release-team] About deploying my first service
by Thomas Brettin 02 Aug '13

02 Aug '13

All the code needs to be committed before Monday morning. Check your type spec for bool typedefs. Remove those. typedef int bool bool is now a reserved word On Aug 2, 2013, at 11:03 AM, Fei He <plane83(a)gmail.com> wrote: > Hi Tom, > > The module, 'functional_ortholog_predictor' has already have some basic function. > I want to deploy this new service next week. This is my first time to deploy a service. Could you give me some guide? > > Thanks. > > -- > Fei He >

1 0

Re: [Release-team] Testing expectations for next week
by Thomas Brettin 02 Aug '13

02 Aug '13

There will be a test for updated RELEASE_NOTES Tom On Aug 2, 2013, at 10:15 AM, "Land, Miriam L." <landml(a)ornl.gov> wrote: > Release Team, > > I want to send out a set of expectations we have of module owners for the build. Anything you would like to add? > > For next week's build, testing will cover: > > * The testing team will go the the test VM for your module and will run 'make test' on your module (initial test) > * If there are no tests in 'make test', this could cause the module to fail testing > * The testing team will attempt to find at least one test for every method in your module (completeness test) > * A dialog will determine if incomplete tests are a warning or a failure. Tom has final say. > * Black box testing will be done on any modules that are new with this build > * There will be a test for the existence of a COMMANDS file? > * Can a list of commands be extracted from the COMMANDS file > * Does each command accept —help as an input and return information that can be included in the user manual > * Is there a release notes file? > * Is the update date on the release notes as current as the module? > > Miriam > _______________________________________________ > Release-team mailing list > Release-team(a)lists.kbase.us > https://lists.kbase.us/mailman/listinfo/release-team

1 0

Testing expectations for next week
by Land, Miriam L. 02 Aug '13

02 Aug '13

Release Team, I want to send out a set of expectations we have of module owners for the build. Anything you would like to add? For next week's build, testing will cover: * The testing team will go the the test VM for your module and will run 'make test' on your module (initial test) * If there are no tests in 'make test', this could cause the module to fail testing * The testing team will attempt to find at least one test for every method in your module (completeness test) * A dialog will determine if incomplete tests are a warning or a failure. Tom has final say. * Black box testing will be done on any modules that are new with this build * There will be a test for the existence of a COMMANDS file? * Can a list of commands be extracted from the COMMANDS file * Does each command accept —help as an input and return information that can be included in the user manual * Is there a release notes file? * Is the update date on the release notes as current as the module? Miriam

1 0