If y'all aren't interested in the updates then just tag typecomp at the last stable, doesn't matter to me. ----- Original Message -----
There's not too many, so I think we should change it ourselves if roll out this change.
But... I'm still not sure the bool type is ready to be rolled out. It works in Perl, but I'm not sure that all client server language combinations will work. I know for sure we will need some changes to the python code, if Gavin hasn't made them this weekend yet. The encoding to bool type in json I think is also handled differently in Perl and java right now. It would have been nice to use a more formal process for rolling out and testing these types of core changes.
I'm about to get on a plane so I'll be offline for most of the day, but I'll try to test and see what issues come up en route.
On Aug 4, 2013 10:19 AM, "Nomi Harris" < [email protected] > wrote:
Tom wrote:
Check your type spec for bool typedefs. Remove those.
typedef int bool
bool is now a reserved word
I found "typedef int bool" in several services:
grep "typedef int bool" */*spec */*/*spec KBaseFBAModeling/fbaModelServices.spec: typedef int bool; experiment/experiment.spec: typedef int boolean; probabilistic_annotation/ProbabilisticAnnotation.spec: typedef int bool; prom_service/PROM.spec: typedef int bool; structured_assertions/SAL.spec: typedef int boolean; trees/Tree.spec: typedef int boolean; workspace_deluxe/workspace.spec: typedef int boolean; kb_seed/lib/CDMI-API.spec: typedef int boolean;
Should we tell the developers or just fix it ourselves? (I can do it.)
Nomi _______________________________________________ Release-team mailing list [email protected] https://lists.kbase.us/mailman/listinfo/release-team
_______________________________________________ Release-team mailing list [email protected] https://lists.kbase.us/mailman/listinfo/release-team