Okay, I'm glad we're all on the same page. So what's the best way to fix this? I suggest: page 579, line 27: For any routine in this section, if the handle argument passed in is not associated with the session argument, MPI_T_ERR_INVALID_HANDLE is returned. page 580, line 17: same text Thoughts? Kathryn On Jul 26, 2013, at 4:51 AM, Jeff Squyres (jsquyres) <[email protected]> wrote:
+1
(meaning: yes -- INVALID_HANDLE :-) )
On Jul 26, 2013, at 2:27 AM, "Schulz, Martin" <[email protected]> wrote:
Yes, sorry - that was a typo on my side: it should be INVALID_HANDLE. I think we are all in agreement.
Martin
On Jul 25, 2013, at 6:29 PM, Anh Vo <[email protected]> wrote:
Yeah, I was a bit confused, too. I agree with Kathryn. Each session has a bunch of handles that were allocated for it, and thus any inquiry should first reference the session, and then the handle. In this case the scope is session2, and handle is not part of session2’s scope, so a search in session2 should not be able to locate the handle, thus MPI_T_ERR_INVALID_HANDLE
--Anh
From: [email protected] [mailto:[email protected]] On Behalf Of Kathryn Mohror Sent: Thursday, July 25, 2013 5:37 PM To: [email protected] Subject: Re: [Mpi3-tools] Bad handle return error code
I suggested MPI_T_ERR_INVALID_HANDLE not SESSION. Is that what you meant?
Kathryn
On Jul 25, 2013, at 4:38 PM, Jeff Squyres (jsquyres) <[email protected]> wrote:
+1
On Jul 25, 2013, at 6:15 PM, "Schulz, Martin" <[email protected]> wrote:
Yes, I agree - the handle is invalid in the session referenced in the argument. Therefore MPI_T_ERR_INVALID_SESSION seems reasonable to me.
Martin
On Jul 25, 2013, at 2:03 PM, Kathryn Mohror <[email protected]> wrote:
Hi everybody,
I got asked a question from Nathan:
What should (MPI_T_pvar_read, _write, _reset, etc) return if bad handle is given?
He gave this example of erroneous code: { MPI_T_pvar_session session1, session2; MPI_T_pvar_handle handle; char buffer[256]; int count;
MPI_T_pvar_session_create (&session1); MPI_T_pvar_session_create (&session2);
MPI_T_pvar_handle_alloc (session1, 0, NULL, &handle, &count);
MPI_T_pvar_start (session1, handle);
/* erroneus statement. should return MPI_T_ERR_INVALID_SESSION or MPI_T_ERR_INVALID_HANDLE */ MPI_T_pvar_read (session2, handle, buffer); }
I argue it should return MPI_T_ERR_INVALID_HANDLE since the session is good, it's just that the handle doesn’t match.
Do you all agree? If so, we should specify it since it's ambiguous. I believe this is an errata item.
Kathryn ______________________________________________________________ Kathryn Mohror, [email protected], http://people.llnl.gov/mohror1 CASC @ Lawrence Livermore National Laboratory, Livermore, CA, USA
_______________________________________________ Mpi3-tools mailing list [email protected] http://lists.mpi-forum.org/mailman/listinfo.cgi/mpi3-tools
________________________________________________________________________ Martin Schulz, [email protected], http://people.llnl.gov/schulzm CASC @ Lawrence Livermore National Laboratory, Livermore, USA
_______________________________________________ Mpi3-tools mailing list [email protected] http://lists.mpi-forum.org/mailman/listinfo.cgi/mpi3-tools
-- Jeff Squyres [email protected] For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
_______________________________________________ Mpi3-tools mailing list [email protected] http://lists.mpi-forum.org/mailman/listinfo.cgi/mpi3-tools
______________________________________________________________ Kathryn Mohror, [email protected], http://people.llnl.gov/mohror1 CASC @ Lawrence Livermore National Laboratory, Livermore, CA, USA
_______________________________________________ Mpi3-tools mailing list [email protected] http://lists.mpi-forum.org/mailman/listinfo.cgi/mpi3-tools
________________________________________________________________________ Martin Schulz, [email protected], http://people.llnl.gov/schulzm CASC @ Lawrence Livermore National Laboratory, Livermore, USA
_______________________________________________ Mpi3-tools mailing list [email protected] http://lists.mpi-forum.org/mailman/listinfo.cgi/mpi3-tools
-- Jeff Squyres [email protected] For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
_______________________________________________ Mpi3-tools mailing list [email protected] http://lists.mpi-forum.org/mailman/listinfo.cgi/mpi3-tools
______________________________________________________________ Kathryn Mohror, [email protected], http://people.llnl.gov/mohror1 CASC @ Lawrence Livermore National Laboratory, Livermore, CA, USA