This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "MPICH primary repository". The branch, master has been updated via 7fa5fe7cd299de9aa58bea3f19e891bc16f5523d (commit) from c5229dfad83e61e8c32902b95de594cbb696db51 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.mpich.org/mpich.git/commitdiff/7fa5fe7cd299de9aa58bea3f19e891bc16... commit 7fa5fe7cd299de9aa58bea3f19e891bc16f5523d Author: Junchao Zhang <[email protected]> Date: Thu Dec 19 13:06:59 2013 -0600 Fix a script problem appearing in old perl Old perl (e.g., Perl 5.10) does not support $_ in readdir. The fix is using an explicit variable instead. Fixes #1991 Signed-off-by: Ken Raffenetti <[email protected]> diff --git a/maint/extractcvars b/maint/extractcvars index f721123..202c027 100755 --- a/maint/extractcvars +++ b/maint/extractcvars @@ -588,15 +588,15 @@ sub ExpandDir { my @subdirs = (); my $DIR_HANDLE; opendir $DIR_HANDLE, "$dir" or die "Error: open directory $dir -- $!\n"; - while (readdir $DIR_HANDLE) { - if (/^\./) { + while (my $filename = readdir $DIR_HANDLE) { + if ($filename =~ /^\./) { next; - } elsif (-d "$dir/$_") { - $subdirs[$#subdirs + 1] = "$dir/$_"; - } elsif (/(.*\.[Cchi])(pp){0,1}$/) { - if (!defined($skipfiles{"$dir/$_"})) + } elsif (-d "$dir/$filename") { + $subdirs[$#subdirs + 1] = "$dir/$filename"; + } elsif ($filename =~ /(.*\.[Cchi])(pp){0,1}$/) { + if (!defined($skipfiles{"$dir/$filename"})) { - $cfiles[$#cfiles + 1] = "$dir/$_"; + $cfiles[$#cfiles + 1] = "$dir/$filename"; } } } ----------------------------------------------------------------------- Summary of changes: maint/extractcvars | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) hooks/post-receive -- MPICH primary repository