This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "MPICH primary repository". The branch, master has been updated via be7c17b3177ccb0ede49761b44a438952360b061 (commit) via 3b04f6c0d9485954f8655a823853f83e6bcdf1bd (commit) from d9c15cf3a93674c129d94ecb5b2e2b13bc186ff9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.mpich.org/mpich.git/commitdiff/be7c17b3177ccb0ede49761b44a4389523... commit be7c17b3177ccb0ede49761b44a438952360b061 Author: Wesley Bland <[email protected]> Date: Fri Feb 13 09:16:25 2015 -0600 Only process recv requests Requests that aren't for receive operations don't have anything in them, so trying to process them only generates valgrind warnings with potentially unsafe behavior. Signed-off-by: Huiwei Lu <[email protected]> diff --git a/src/mpi/coll/helper_fns.c b/src/mpi/coll/helper_fns.c index 1746430..1e5daa4 100644 --- a/src/mpi/coll/helper_fns.c +++ b/src/mpi/coll/helper_fns.c @@ -228,7 +228,8 @@ int MPIC_Wait(MPID_Request * request_ptr, mpir_errflag_t *errflag) MPID_Progress_end(&progress_state); } - MPIR_Process_status(&request_ptr->status, errflag); + if (request_ptr->kind == MPID_REQUEST_RECV) + MPIR_Process_status(&request_ptr->status, errflag); fn_exit: MPIU_DBG_MSG_D(PT2PT, TYPICAL, "OUT: errflag = %d", *errflag); http://git.mpich.org/mpich.git/commitdiff/3b04f6c0d9485954f8655a823853f83e6b... commit 3b04f6c0d9485954f8655a823853f83e6bcdf1bd Author: Wesley Bland <[email protected]> Date: Tue Feb 10 13:27:15 2015 -0600 Don't check for anysource if not recv The function to check whether an operation was an anysource receive was checking all request kinds, even if they weren't receives. This limits that check to only receives to avoid examining an uninitialized variable. Signed-off-by: Huiwei Lu <[email protected]> diff --git a/src/mpid/ch3/src/mpid_comm_failure_ack.c b/src/mpid/ch3/src/mpid_comm_failure_ack.c index e8d836c..377a831 100644 --- a/src/mpid/ch3/src/mpid_comm_failure_ack.c +++ b/src/mpid/ch3/src/mpid_comm_failure_ack.c @@ -162,5 +162,10 @@ int MPID_Comm_AS_enabled(MPID_Comm *comm_ptr) { #undef FCNAME #define FCNAME MPIU_QUOTE(FUNCNAME) int MPID_Request_is_anysource(MPID_Request *request_ptr) { - return request_ptr->dev.match.parts.rank == MPI_ANY_SOURCE; + int ret = 0; + + if (request_ptr->kind == MPID_REQUEST_RECV) + ret = request_ptr->dev.match.parts.rank == MPI_ANY_SOURCE; + + return ret; } ----------------------------------------------------------------------- Summary of changes: src/mpi/coll/helper_fns.c | 3 ++- src/mpid/ch3/src/mpid_comm_failure_ack.c | 7 ++++++- 2 files changed, 8 insertions(+), 2 deletions(-) hooks/post-receive -- MPICH primary repository