February 2016 - commits - mailman3.cels.anl.gov

[mpich] MPICH primary repository branch, master, updated. v3.2-184-g60ca21c
by noreply＠mpich.org 15 Feb '16

15 Feb '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "MPICH primary repository". The branch, master has been updated via 60ca21cf73d3cd3d74d36ac4bae50f37d904dfc9 (commit) via 7fddec5638fff514e808cb9dff7ad6b424b8596c (commit) via c9254112baaf7d6cd5697fcb6101d90ff6f227c5 (commit) via fb99a5964796bad5b2abd67281dac2863f275404 (commit) via d3d0ae55ec02f80a78c3cf0a739549c0313fcd90 (commit) via 927f18ea9a0fb24e0812ae8776d191162f5474a5 (commit) from 62f750cca300118d22a4ba2d77968343b0acfd53 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.mpich.org/mpich.git/commitdiff/60ca21cf73d3cd3d74d36ac4bae50f37d… commit 60ca21cf73d3cd3d74d36ac4bae50f37d904dfc9 Author: Pavan Balaji <balaji(a)anl.gov> Date: Sat Feb 13 20:10:08 2016 -0600 Bug-fix: release RMA progress hook correctly. We should check for both active and inactive lists. This was a bug causing the RMA progress hook to get released even when one of the lists was not NULL. Signed-off-by: Xin Zhao <xinzhao3(a)illinois.edu> diff --git a/src/mpid/ch3/src/mpidi_rma.c b/src/mpid/ch3/src/mpidi_rma.c index 53cf8c7..590f30a 100644 --- a/src/mpid/ch3/src/mpidi_rma.c +++ b/src/mpid/ch3/src/mpidi_rma.c @@ -193,7 +193,7 @@ int MPID_Win_free(MPID_Win ** win_ptr) MPIU_Assert((*win_ptr)->active == FALSE); MPL_DL_DELETE(MPIDI_RMA_Win_inactive_list_head, (*win_ptr)); - if (MPIDI_RMA_Win_inactive_list_head == NULL && MPIDI_RMA_Win_inactive_list_head == NULL) { + if (MPIDI_RMA_Win_inactive_list_head == NULL && MPIDI_RMA_Win_active_list_head == NULL) { /* this is the last window, de-register RMA progress hook */ mpi_errno = MPID_Progress_deregister_hook(MPIDI_CH3I_RMA_Progress_hook_id); if (mpi_errno != MPI_SUCCESS) { http://git.mpich.org/mpich.git/commitdiff/7fddec5638fff514e808cb9dff7ad6b42… commit 7fddec5638fff514e808cb9dff7ad6b424b8596c Author: Pavan Balaji <balaji(a)anl.gov> Date: Sat Feb 13 17:21:05 2016 -0600 fix initializations. In some cases, we would end up using the uninitialized variables. Initialize at the start to avoid such cases. Signed-off-by: Ken Raffenetti <raffenet(a)mcs.anl.gov> diff --git a/src/pm/hydra/tools/bootstrap/src/bsci_init.c.in b/src/pm/hydra/tools/bootstrap/src/bsci_init.c.in index ae4df63..d48a548 100644 --- a/src/pm/hydra/tools/bootstrap/src/bsci_init.c.in +++ b/src/pm/hydra/tools/bootstrap/src/bsci_init.c.in @@ -45,7 +45,7 @@ static void init_bsci_info(void) static const char *detect_rmk(int debug) { - int i, ret; + int i, ret = 0; HYD_status status = HYD_SUCCESS; for (i = 0; rmk_array[i]; i++) { diff --git a/src/pm/hydra/utils/args/args.c b/src/pm/hydra/utils/args/args.c index 8303bd7..bc7ea5e 100644 --- a/src/pm/hydra/utils/args/args.c +++ b/src/pm/hydra/utils/args/args.c @@ -360,7 +360,7 @@ HYD_status HYDU_parse_hostfile(const char *hostfile, struct HYD_node **node_list char *HYDU_find_full_path(const char *execname) { - char *tmp[HYD_NUM_TMP_STRINGS], *path = NULL, *test_path = NULL; + char *tmp[HYD_NUM_TMP_STRINGS] = { NULL }, *path = NULL, *test_path = NULL; HYD_status status = HYD_SUCCESS; HYDU_FUNC_ENTER(); http://git.mpich.org/mpich.git/commitdiff/c9254112baaf7d6cd5697fcb6101d90ff… commit c9254112baaf7d6cd5697fcb6101d90ff6f227c5 Author: Pavan Balaji <balaji(a)anl.gov> Date: Sat Feb 13 17:12:12 2016 -0600 Added additional error checking. We were capturing the error, but were not doing anything with the captured error code. This patch at least jumps to fail in such cases and returns the error instead of simply overwriting the error in the next statement. Signed-off-by: Ken Raffenetti <raffenet(a)mcs.anl.gov> diff --git a/src/mpi/coll/red_scat.c b/src/mpi/coll/red_scat.c index 5eb3595..9e26f0d 100644 --- a/src/mpi/coll/red_scat.c +++ b/src/mpi/coll/red_scat.c @@ -835,10 +835,13 @@ int MPIR_Reduce_scatter_intra(const void *sendbuf, void *recvbuf, const int recv mpi_errno = MPIR_Reduce_local_impl( tmp_recvbuf, tmp_results, blklens[0], datatype, op); + if (mpi_errno) MPIR_ERR_POP(mpi_errno); + mpi_errno = MPIR_Reduce_local_impl( ((char *)tmp_recvbuf + dis[1]*extent), ((char *)tmp_results + dis[1]*extent), blklens[1], datatype, op); + if (mpi_errno) MPIR_ERR_POP(mpi_errno); } } else { @@ -846,10 +849,13 @@ int MPIR_Reduce_scatter_intra(const void *sendbuf, void *recvbuf, const int recv mpi_errno = MPIR_Reduce_local_impl( tmp_results, tmp_recvbuf, blklens[0], datatype, op); + if (mpi_errno) MPIR_ERR_POP(mpi_errno); + mpi_errno = MPIR_Reduce_local_impl( ((char *)tmp_results + dis[1]*extent), ((char *)tmp_recvbuf + dis[1]*extent), blklens[1], datatype, op); + if (mpi_errno) MPIR_ERR_POP(mpi_errno); } /* copy result back into tmp_results */ mpi_errno = MPIR_Localcopy(tmp_recvbuf, 1, recvtype, diff --git a/src/mpi/coll/red_scat_block.c b/src/mpi/coll/red_scat_block.c index 28c6b17..1ca4b8e 100644 --- a/src/mpi/coll/red_scat_block.c +++ b/src/mpi/coll/red_scat_block.c @@ -809,19 +809,26 @@ int MPIR_Reduce_scatter_block_intra ( mpi_errno = MPIR_Reduce_local_impl( tmp_recvbuf, tmp_results, blklens[0], datatype, op); + if (mpi_errno) MPIR_ERR_POP(mpi_errno); + mpi_errno = MPIR_Reduce_local_impl( ((char *)tmp_recvbuf + dis[1]*extent), ((char *)tmp_results + dis[1]*extent), blklens[1], datatype, op); + if (mpi_errno) MPIR_ERR_POP(mpi_errno); } else { mpi_errno = MPIR_Reduce_local_impl( tmp_results, tmp_recvbuf, blklens[0], datatype, op); + if (mpi_errno) MPIR_ERR_POP(mpi_errno); + mpi_errno = MPIR_Reduce_local_impl( ((char *)tmp_results + dis[1]*extent), ((char *)tmp_recvbuf + dis[1]*extent), blklens[1], datatype, op); + if (mpi_errno) MPIR_ERR_POP(mpi_errno); + /* copy result back into tmp_results */ mpi_errno = MPIR_Localcopy(tmp_recvbuf, 1, recvtype, tmp_results, 1, recvtype); diff --git a/src/mpid/ch3/src/ch3u_port.c b/src/mpid/ch3/src/ch3u_port.c index 6ff7cc5..d1f966b 100644 --- a/src/mpid/ch3/src/ch3u_port.c +++ b/src/mpid/ch3/src/ch3u_port.c @@ -1024,8 +1024,10 @@ int MPIDI_Comm_accept(const char *port_name, MPID_Info *info, int root, distributes them to the processes in comm_ptr */ mpi_errno = ReceivePGAndDistribute( tmp_comm, comm_ptr, root, &recvtag, n_remote_pgs, remote_pg ); + if (mpi_errno) MPIR_ERR_POP(mpi_errno); mpi_errno = SendPGtoPeerAndFree( tmp_comm, &sendtag, pg_list ); + if (mpi_errno) MPIR_ERR_POP(mpi_errno); /* Receive the translations from remote process rank to process group index */ /*printf("accept:sending %d ints and receiving %d ints\n", local_comm_size * 2, remote_comm_size * 2);fflush(stdout);*/ @@ -1034,6 +1036,8 @@ int MPIDI_Comm_accept(const char *port_name, MPID_Info *info, int root, remote_translation, remote_comm_size * 2, MPI_INT, 0, recvtag++, tmp_comm, MPI_STATUS_IGNORE, &errflag); + if (mpi_errno) MPIR_ERR_POP(mpi_errno); + #ifdef MPICH_DBG_OUTPUT MPL_DBG_MSG_D(MPIDI_CH3_DBG_OTHER,TERSE,"[%d]accept:Received remote_translation:\n", rank); for (i=0; i<remote_comm_size; i++) diff --git a/src/pm/hydra/pm/pmiserv/pmip_cb.c b/src/pm/hydra/pm/pmiserv/pmip_cb.c index 316c01c..7fe88f0 100644 --- a/src/pm/hydra/pm/pmiserv/pmip_cb.c +++ b/src/pm/hydra/pm/pmiserv/pmip_cb.c @@ -549,6 +549,8 @@ static HYD_status launch_procs(void) HYD_pmcd_pmip.downstream.err, HYD_pmcd_pmip.downstream.pid, HYD_pmcd_pmip.local.ckpoint_prefix_list[0]); + HYDU_ERR_POP(status, "unable to restart from checkpoint\n"); + goto fn_spawn_complete; } diff --git a/src/pm/hydra/ui/utils/uiu.c b/src/pm/hydra/ui/utils/uiu.c index 4b89134..f935442 100644 --- a/src/pm/hydra/ui/utils/uiu.c +++ b/src/pm/hydra/ui/utils/uiu.c @@ -320,6 +320,7 @@ static HYD_status stdoe_cb(int _fd, int pgid, int proxy_id, int rank, void *_buf status = HYDU_sock_write(fd, (const void *) prepend, strlen(prepend), &sent, &closed, HYDU_SOCK_COMM_MSGWAIT); + HYDU_ERR_POP(status, "unable to write data to stdout/stderr\n"); } status = HYDU_sock_write(fd, (const void *) &buf[mark], i - mark + 1, &sent, &closed, HYDU_SOCK_COMM_MSGWAIT); diff --git a/src/pmi/simple/simple_pmi.c b/src/pmi/simple/simple_pmi.c index 33ea5db..05859f4 100644 --- a/src/pmi/simple/simple_pmi.c +++ b/src/pmi/simple/simple_pmi.c @@ -603,6 +603,8 @@ int PMI_Spawn_multiple(int count, } argcnt++; rc = PMIU_writeline( PMI_fd, buf ); + if (rc) + return PMI_FAIL; buf[0] = 0; } http://git.mpich.org/mpich.git/commitdiff/fb99a5964796bad5b2abd67281dac2863… commit fb99a5964796bad5b2abd67281dac2863f275404 Author: Pavan Balaji <balaji(a)anl.gov> Date: Sat Feb 13 17:07:15 2016 -0600 remove unnecessary statement. The variable is immediately overwritten in the next statement, making this statement irrelevant. Signed-off-by: Ken Raffenetti <raffenet(a)mcs.anl.gov> diff --git a/src/mpi/coll/ired_scat_block.c b/src/mpi/coll/ired_scat_block.c index 6960ed0..05d4367 100644 --- a/src/mpi/coll/ired_scat_block.c +++ b/src/mpi/coll/ired_scat_block.c @@ -497,7 +497,6 @@ int MPIR_Ireduce_scatter_block_rec_dbl(const void *sendbuf, void *recvbuf, int r blklens[1] = 0; dis[0] = 0; - dis[1] = blklens[0]; dis[1] = blklens[0] + recvcount * (MPL_MIN((dst_tree_root + mask), comm_size) - dst_tree_root); mpi_errno = MPIR_Type_indexed_impl(2, blklens, dis, datatype, &recvtype); http://git.mpich.org/mpich.git/commitdiff/d3d0ae55ec02f80a78c3cf0a739549c03… commit d3d0ae55ec02f80a78c3cf0a739549c0313fcd90 Author: Pavan Balaji <balaji(a)anl.gov> Date: Sat Feb 13 17:00:40 2016 -0600 romio: fixup weird pointer comparison. What does a '< 0' comparison even mean for a pointer. Looks like some weird unexplained logic. Changing it to a simple NULL comparison. Signed-off-by: Rob Latham <robl(a)mcs.anl.gov> diff --git a/src/mpi/romio/mpi-io/glue/default/mpio_file.c b/src/mpi/romio/mpi-io/glue/default/mpio_file.c index 7a43b01..38222f7 100644 --- a/src/mpi/romio/mpi-io/glue/default/mpio_file.c +++ b/src/mpi/romio/mpi-io/glue/default/mpio_file.c @@ -66,7 +66,7 @@ MPI_Fint MPIO_File_c2f(MPI_File fh) #else int i; - if ((fh <= (MPI_File) 0) || (fh->cookie != ADIOI_FILE_COOKIE)) + if ((fh == NULL) || (fh->cookie != ADIOI_FILE_COOKIE)) return (MPI_Fint) 0; if (!ADIOI_Ftable) { ADIOI_Ftable_max = 1024; diff --git a/src/mpi/romio/mpi-io/glue/mpich/mpio_file.c b/src/mpi/romio/mpi-io/glue/mpich/mpio_file.c index 6f6c902..a5e54a7 100644 --- a/src/mpi/romio/mpi-io/glue/mpich/mpio_file.c +++ b/src/mpi/romio/mpi-io/glue/mpich/mpio_file.c @@ -63,7 +63,7 @@ MPI_Fint MPIO_File_c2f(MPI_File fh) #else int i; - if ((fh <= (MPI_File) 0) || (fh->cookie != ADIOI_FILE_COOKIE)) + if ((fh == NULL) || (fh->cookie != ADIOI_FILE_COOKIE)) return (MPI_Fint) 0; if (fh->fortran_handle != -1) diff --git a/src/mpi/romio/mpi-io/glue/openmpi/mpio_file.c b/src/mpi/romio/mpi-io/glue/openmpi/mpio_file.c index e3ac2e7..f0b6d51 100644 --- a/src/mpi/romio/mpi-io/glue/openmpi/mpio_file.c +++ b/src/mpi/romio/mpi-io/glue/openmpi/mpio_file.c @@ -68,7 +68,7 @@ MPI_Fint MPIO_File_c2f(MPI_File fh) #else int i; - if ((fh <= (MPI_File) 0) || (fh->cookie != ADIOI_FILE_COOKIE)) + if ((fh == NULL) || (fh->cookie != ADIOI_FILE_COOKIE)) return (MPI_Fint) 0; if (!ADIOI_Ftable) { ADIOI_Ftable_max = 1024; http://git.mpich.org/mpich.git/commitdiff/927f18ea9a0fb24e0812ae8776d191162… commit 927f18ea9a0fb24e0812ae8776d191162f5474a5 Author: Pavan Balaji <balaji(a)anl.gov> Date: Sat Feb 13 16:57:40 2016 -0600 Bug-fix: incorrect assertion. The assertion was doing an assignment ('=') instead of a check ('==') for whether the data fits inside an integer. Signed-off-by: Xin Zhao <xinzhao3(a)illinois.edu> diff --git a/src/mpid/ch3/src/ch3u_handle_recv_req.c b/src/mpid/ch3/src/ch3u_handle_recv_req.c index fe167bd..c2c7ec2 100644 --- a/src/mpid/ch3/src/ch3u_handle_recv_req.c +++ b/src/mpid/ch3/src/ch3u_handle_recv_req.c @@ -1327,7 +1327,7 @@ static inline int perform_acc_in_lock_queue(MPID_Win * win_ptr, /* Note: here stream_offset is 0 because when piggybacking LOCK, we must use * the first stream unit. */ - MPIU_Assert(recv_count = (int) recv_count); + MPIU_Assert(recv_count == (int) recv_count); mpi_errno = do_accumulate_op(target_lock_entry->data, (int) recv_count, acc_pkt->datatype, acc_pkt->addr, acc_pkt->count, acc_pkt->datatype, 0, acc_pkt->op); ----------------------------------------------------------------------- Summary of changes: src/mpi/coll/ired_scat_block.c | 1 - src/mpi/coll/red_scat.c | 6 ++++++ src/mpi/coll/red_scat_block.c | 7 +++++++ src/mpi/romio/mpi-io/glue/default/mpio_file.c | 2 +- src/mpi/romio/mpi-io/glue/mpich/mpio_file.c | 2 +- src/mpi/romio/mpi-io/glue/openmpi/mpio_file.c | 2 +- src/mpid/ch3/src/ch3u_handle_recv_req.c | 2 +- src/mpid/ch3/src/ch3u_port.c | 4 ++++ src/mpid/ch3/src/mpidi_rma.c | 2 +- src/pm/hydra/pm/pmiserv/pmip_cb.c | 2 ++ src/pm/hydra/tools/bootstrap/src/bsci_init.c.in | 2 +- src/pm/hydra/ui/utils/uiu.c | 1 + src/pm/hydra/utils/args/args.c | 2 +- src/pmi/simple/simple_pmi.c | 2 ++ 14 files changed, 29 insertions(+), 8 deletions(-) hooks/post-receive -- MPICH primary repository

1 0

[mpich] MPICH primary repository branch, master, updated. v3.2-178-g62f750c
by noreply＠mpich.org 12 Feb '16

12 Feb '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "MPICH primary repository". The branch, master has been updated via 62f750cca300118d22a4ba2d77968343b0acfd53 (commit) via aaf2fd8548a58f7ff5ca3c9092f48ad9a766d2e5 (commit) via aeb114962d94292260dd5e8e48f3d1818d15aa78 (commit) from 378afdc73a87e95a8c94d5da003d98c81f99f1cf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.mpich.org/mpich.git/commitdiff/62f750cca300118d22a4ba2d77968343b… commit 62f750cca300118d22a4ba2d77968343b0acfd53 Author: Adam T. Moody <moody20(a)llnl.gov> Date: Tue Feb 9 17:49:16 2016 -0800 Fix fall-through bug in external32 pack In a call to MPI_File_write_at_all using external32, the ext32 buffer has been overwritten when it's freed. BASIC_convert96 and BASIC_convert128 are being called here, but it should only be calling BASIC_convert64 for a 64-bit float. There are some missing "break" statements in mpid_ext32_segment.h, so for 64-bit floats it ends up executing all three functions one after another. Signed-off-by: Rob Latham <robl(a)mcs.anl.gov> diff --git a/src/mpid/common/datatype/mpid_ext32_segment.h b/src/mpid/common/datatype/mpid_ext32_segment.h index 97eff20..f643e3f 100644 --- a/src/mpid/common/datatype/mpid_ext32_segment.h +++ b/src/mpid/common/datatype/mpid_ext32_segment.h @@ -348,11 +348,13 @@ static inline void BASIC_convert128(char *src, char *dest) BASIC_convert64((char *)&src, \ (char *)&dest);\ } \ + break; \ case 12: \ { \ BASIC_convert96((char *)&src, \ (char *)&dest); \ } \ + break; \ case 16: \ { \ BASIC_convert128((char *)&src, \ http://git.mpich.org/mpich.git/commitdiff/aaf2fd8548a58f7ff5ca3c9092f48ad9a… commit aaf2fd8548a58f7ff5ca3c9092f48ad9a766d2e5 Author: Rob Latham <robl(a)mcs.anl.gov> Date: Thu Feb 4 15:15:45 2016 -0600 the 'status' field was being used uninitialized Michael Raymond (SGI) found this with his static analyiss tools. No reviewer. diff --git a/src/mpi/romio/adio/ad_gpfs/ad_gpfs_wrcoll.c b/src/mpi/romio/adio/ad_gpfs/ad_gpfs_wrcoll.c index eae6ad5..d2c507c 100644 --- a/src/mpi/romio/adio/ad_gpfs/ad_gpfs_wrcoll.c +++ b/src/mpi/romio/adio/ad_gpfs/ad_gpfs_wrcoll.c @@ -918,7 +918,7 @@ static void ADIOI_Exch_and_write(ADIO_File fd, const void *buf, MPI_Datatype io_thread_args.io_kind = ADIOI_WRITE; io_thread_args.size = size; io_thread_args.offset = off; - io_thread_args.status = status; + io_thread_args.status = &status; io_thread_args.error_code = *error_code; if ( (pthread_create(&io_thread, NULL, ADIOI_IO_Thread_Func, &(io_thread_args))) != 0) diff --git a/src/mpi/romio/adio/common/ad_threaded_io.c b/src/mpi/romio/adio/common/ad_threaded_io.c index a4b3da3..2436a7a 100644 --- a/src/mpi/romio/adio/common/ad_threaded_io.c +++ b/src/mpi/romio/adio/common/ad_threaded_io.c @@ -21,11 +21,11 @@ void *ADIOI_IO_Thread_Func(void *vptr_args) { if (args->io_kind == ADIOI_READ) { ADIO_ReadContig(args->fd, args->buf, args->size, MPI_BYTE, ADIO_EXPLICIT_OFFSET, args->offset, - &(args->status), &(args->error_code)); + args->status, &(args->error_code)); } else { ADIO_WriteContig(args->fd, args->buf, args->size, MPI_BYTE, ADIO_EXPLICIT_OFFSET, args->offset, - &(args->status), &(args->error_code)); + args->status, &(args->error_code)); } pthread_exit(&(args->error_code)); return NULL; diff --git a/src/mpi/romio/adio/common/onesided_aggregation.c b/src/mpi/romio/adio/common/onesided_aggregation.c index 0c0a5dd..35e0a82 100644 --- a/src/mpi/romio/adio/common/onesided_aggregation.c +++ b/src/mpi/romio/adio/common/onesided_aggregation.c @@ -1124,7 +1124,7 @@ printf("first barrier roundIter %d\n",roundIter); io_thread_args.io_kind = ADIOI_WRITE; io_thread_args.size = (currentRoundFDEnd-currentRoundFDStart) + 1; io_thread_args.offset = currentRoundFDStart; - io_thread_args.status = status; + io_thread_args.status = &status; io_thread_args.error_code = *error_code; if ( (pthread_create(&io_thread, NULL, @@ -1898,7 +1898,7 @@ printf("iAmUsedAgg - currentRoundFDStart initialized " io_thread_args.io_kind = ADIOI_READ; io_thread_args.size = amountDataToReadNextRound; io_thread_args.offset = nextRoundFDStart; - io_thread_args.status = status; + io_thread_args.status = &status; io_thread_args.error_code = *error_code; if ( (pthread_create(&io_thread, NULL, ADIOI_IO_Thread_Func, &(io_thread_args))) != 0) diff --git a/src/mpi/romio/adio/common/p2p_aggregation.c b/src/mpi/romio/adio/common/p2p_aggregation.c index 9804503..ac77a8f 100644 --- a/src/mpi/romio/adio/common/p2p_aggregation.c +++ b/src/mpi/romio/adio/common/p2p_aggregation.c @@ -423,7 +423,7 @@ void ADIOI_P2PContigWriteAggregation(ADIO_File fd, io_thread_args.io_kind = ADIOI_WRITE; io_thread_args.size = totalDataReceivedThisRound; io_thread_args.offset = currentRoundFDStart; - io_thread_args.status = status; + io_thread_args.status = &status; io_thread_args.error_code = *error_code; if ( (pthread_create(&io_thread, NULL, ADIOI_IO_Thread_Func, &(io_thread_args))) != 0) @@ -722,7 +722,7 @@ void ADIOI_P2PContigReadAggregation(ADIO_File fd, io_thread_args.io_kind = ADIOI_READ; io_thread_args.size = amountDataToReadNextRound; io_thread_args.offset = nextRoundFDStart; - io_thread_args.status = status; + io_thread_args.status = &status; io_thread_args.error_code = *error_code; if ( (pthread_create(&io_thread, NULL, ADIOI_IO_Thread_Func, &(io_thread_args))) != 0) diff --git a/src/mpi/romio/adio/include/adioi.h b/src/mpi/romio/adio/include/adioi.h index 26116f9..bc00a87 100644 --- a/src/mpi/romio/adio/include/adioi.h +++ b/src/mpi/romio/adio/include/adioi.h @@ -1046,7 +1046,7 @@ typedef struct wcThreadFuncData { char *buf; int size; ADIO_Offset offset; - ADIO_Status status; + ADIO_Status *status; int error_code; } ADIOI_IO_ThreadFuncData; http://git.mpich.org/mpich.git/commitdiff/aeb114962d94292260dd5e8e48f3d1818… commit aeb114962d94292260dd5e8e48f3d1818d15aa78 Author: Rob Latham <robl(a)mcs.anl.gov> Date: Wed Sep 23 16:56:26 2015 -0500 A comment about our use of MPIU_trmalloc Calling MPIU_trmalloc directly is an old hack to avoid some build system complications. It is highly unusual, so drop a comment explaining. No reviewer. diff --git a/src/mpi/romio/adio/common/malloc.c b/src/mpi/romio/adio/common/malloc.c index 6323942..7f3462b 100644 --- a/src/mpi/romio/adio/common/malloc.c +++ b/src/mpi/romio/adio/common/malloc.c @@ -37,6 +37,12 @@ void *ADIOI_Calloc_fn(size_t nelem, size_t elsize, int lineno, const char *fname void *ADIOI_Realloc_fn(void *ptr, size_t size, int lineno, const char *fname); void ADIOI_Free_fn(void *ptr, int lineno, const char *fname); +/* we used to call MPIU_Malloc, MPIU_Calloc, etc. these macros either call + * malloc/calloc directly or they add instrumentation/tracing. When we re-did + * the build system in 2011 we hacked ROMIO to call MPIU_trmalloc directly -- + * once again ROMIO's sort-of standalone status bites us. We dont' test for + * MPIU_FUNCS: these are set in configure with an AC_DEFINE when we figure out + * we are built as part of MPICH */ void *ADIOI_Malloc_fn(size_t size, int lineno, const char *fname) { void *new; ----------------------------------------------------------------------- Summary of changes: src/mpi/romio/adio/ad_gpfs/ad_gpfs_wrcoll.c | 2 +- src/mpi/romio/adio/common/ad_threaded_io.c | 4 ++-- src/mpi/romio/adio/common/malloc.c | 6 ++++++ src/mpi/romio/adio/common/onesided_aggregation.c | 4 ++-- src/mpi/romio/adio/common/p2p_aggregation.c | 4 ++-- src/mpi/romio/adio/include/adioi.h | 2 +- src/mpid/common/datatype/mpid_ext32_segment.h | 2 ++ 7 files changed, 16 insertions(+), 8 deletions(-) hooks/post-receive -- MPICH primary repository

1 0

[mpich] MPICH primary repository branch, master, updated. v3.2-175-g378afdc
by noreply＠mpich.org 11 Feb '16

11 Feb '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "MPICH primary repository". The branch, master has been updated via 378afdc73a87e95a8c94d5da003d98c81f99f1cf (commit) from 410add1042cbd467288c83ffec437c549c93cea3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.mpich.org/mpich.git/commitdiff/378afdc73a87e95a8c94d5da003d98c81… commit 378afdc73a87e95a8c94d5da003d98c81f99f1cf Author: Charles J Archer <charles.j.archer(a)intel.com> Date: Thu Feb 11 08:44:40 2016 -0800 confdb/aclocal_libs.m4: PAC_SET_HEADER_LIB_PATH fixup Fixes typo in path processing for lib64 directories. Signed-off-by: Ken Raffenetti <raffenet(a)mcs.anl.gov> diff --git a/confdb/aclocal_libs.m4 b/confdb/aclocal_libs.m4 index 09e9c4c..8868e99 100644 --- a/confdb/aclocal_libs.m4 +++ b/confdb/aclocal_libs.m4 @@ -48,7 +48,7 @@ AC_DEFUN([PAC_SET_HEADER_LIB_PATH],[ dnl is adding lib64 by default really the right thing to do? What if dnl we are on a 32-bit host that happens to have both lib dirs available? [PAC_APPEND_FLAG([-L${with_$1}/lib],[LDFLAGS]) - AS_IF([test -d "${with_$1}/lib64}"], + AS_IF([test -d "${with_$1}/lib64"], [PAC_APPEND_FLAG([-L${with_$1}/lib64],[LDFLAGS])]) ]) ]) ----------------------------------------------------------------------- Summary of changes: confdb/aclocal_libs.m4 | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- MPICH primary repository

1 0

[mpich] MPICH primary repository branch, master, updated. v3.2-174-g410add1
by noreply＠mpich.org 05 Feb '16

05 Feb '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "MPICH primary repository". The branch, master has been updated via 410add1042cbd467288c83ffec437c549c93cea3 (commit) via aec9468d5d52d8e780522ce78b4692104c4d8e60 (commit) via 7f4206c121b5bb251de90da07161fa414046ffc0 (commit) from 14c326b77674d7215fc32d809a21048ebfcded6f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.mpich.org/mpich.git/commitdiff/410add1042cbd467288c83ffec437c549… commit 410add1042cbd467288c83ffec437c549c93cea3 Author: Ken Raffenetti <raffenet(a)mcs.anl.gov> Date: Thu Feb 4 09:51:18 2016 -0600 test/mpi/spawn: remove xfail for spawn-rootargs Closes #2282 Signed-off-by: Pavan Balaji <balaji(a)anl.gov> diff --git a/test/mpi/spawn/testlist.in b/test/mpi/spawn/testlist.in index e497105..586322d 100644 --- a/test/mpi/spawn/testlist.in +++ b/test/mpi/spawn/testlist.in @@ -26,4 +26,4 @@ disconnect3 3 concurrent_spawns 1 pgroup_connect_test 4 pgroup_intercomm_test 4 -spawn-rootargs 10 xfail=ticket2282 +spawn-rootargs 10 http://git.mpich.org/mpich.git/commitdiff/aec9468d5d52d8e780522ce78b4692104… commit aec9468d5d52d8e780522ce78b4692104c4d8e60 Author: Ken Raffenetti <raffenet(a)mcs.anl.gov> Date: Tue Feb 2 18:14:52 2016 -0600 test/mpi/spawn: fixup spawn-rootargs test MPI_Comm_spawn should launch new instances of "spawn-rootargs" for this test to succeed. There is no "spawn-nullargs" binary. Signed-off-by: Pavan Balaji <balaji(a)anl.gov> diff --git a/test/mpi/spawn/spawn-rootargs.c b/test/mpi/spawn/spawn-rootargs.c index a6a135a..1657d3e 100644 --- a/test/mpi/spawn/spawn-rootargs.c +++ b/test/mpi/spawn/spawn-rootargs.c @@ -26,7 +26,7 @@ int main(int argc, char *argv[]) if (master == MPI_COMM_NULL) { MPI_Comm_rank(MPI_COMM_WORLD, &rank); - MPI_Comm_spawn("./spawn-nullargs", args, /*MPI_ARGV_NULL, */ + MPI_Comm_spawn("./spawn-rootargs", args, /*MPI_ARGV_NULL, */ 5, MPI_INFO_NULL, 0, MPI_COMM_SELF, &worker, MPI_ERRCODES_IGNORE); MPI_Barrier(worker); MPI_Comm_disconnect(&worker); http://git.mpich.org/mpich.git/commitdiff/7f4206c121b5bb251de90da07161fa414… commit 7f4206c121b5bb251de90da07161fa414046ffc0 Author: Ken Raffenetti <raffenet(a)mcs.anl.gov> Date: Tue Feb 2 18:08:58 2016 -0600 pm/hydra: fix pmi mcmd interleaving problem Incomplete PMI-1 mcmds suffer from an interleaving problem when there are multiple commands written to the PMI proxy server from different procs at the same time. This commit forces the server to block until the full mcmd is read and processed. Refs #2282 Algo: - If we do not have a full command, read more from the fd. - If pmi_storage has multiple commands, process all of them, even if that means reading more from the fd. - else break; Signed-off-by: Pavan Balaji <balaji(a)anl.gov> diff --git a/src/pm/hydra/pm/pmiserv/pmip_cb.c b/src/pm/hydra/pm/pmiserv/pmip_cb.c index 1866f29..316c01c 100644 --- a/src/pm/hydra/pm/pmiserv/pmip_cb.c +++ b/src/pm/hydra/pm/pmiserv/pmip_cb.c @@ -214,15 +214,6 @@ static HYD_status pmi_cb(int fd, HYD_event_t events, void *userp) HYD_pmcd_init_header(&hdr); - /* PMI-1 does not tell us how much to read. We read how much ever - * we can, parse out full PMI commands from it, and process - * them. When we don't have a full PMI command, we store the - * rest. */ - status = - HYDU_sock_read(fd, pmi_storage + pmi_storage_len, HYD_TMPBUF_SIZE - pmi_storage_len, - &linelen, &closed, HYDU_SOCK_COMM_NONE); - HYDU_ERR_POP(status, "unable to read PMI command\n"); - /* Try to find the PMI FD */ for (i = 0; i < HYD_pmcd_pmip.local.proxy_process_count; i++) { if (HYD_pmcd_pmip.downstream.pmi_fd[i] == fd) { @@ -231,6 +222,17 @@ static HYD_status pmi_cb(int fd, HYD_event_t events, void *userp) } } + read_cmd: + /* PMI-1 does not tell us how much to read. We read how much ever + * we can, parse out full PMI commands from it, and process + * them. When we don't have a full PMI command, we go back and + * read from the same FD until we do. PMI clients (1 and 2) always + * send full commands, then wait for response. */ + status = + HYDU_sock_read(fd, pmi_storage + pmi_storage_len, HYD_TMPBUF_SIZE - pmi_storage_len, + &linelen, &closed, HYDU_SOCK_COMM_NONE); + HYDU_ERR_POP(status, "unable to read PMI command\n"); + if (closed) { /* If a PMI application terminates, we clean up the remaining * processes. For a correct PMI application, we should never @@ -282,6 +284,14 @@ static HYD_status pmi_cb(int fd, HYD_event_t events, void *userp) pmi_storage[pmi_storage_len] = 0; } + check_cmd: + status = check_pmi_cmd(&buf, &hdr.pmi_version, &repeat); + HYDU_ERR_POP(status, "error checking the PMI command\n"); + + if (buf == NULL) + /* read more to get a full command. */ + goto read_cmd; + /* We were able to read the PMI command correctly. If we were able * to identify what PMI FD this is, activate it. If we were not * able to identify the PMI FD, we will activate it when we get @@ -289,62 +299,57 @@ static HYD_status pmi_cb(int fd, HYD_event_t events, void *userp) if (pid != -1 && !HYD_pmcd_pmip.downstream.pmi_fd_active[pid]) HYD_pmcd_pmip.downstream.pmi_fd_active[pid] = 1; - do { - status = check_pmi_cmd(&buf, &hdr.pmi_version, &repeat); - HYDU_ERR_POP(status, "error checking the PMI command\n"); - - if (buf == NULL) - break; - - if (hdr.pmi_version == 1) - HYD_pmcd_pmip_pmi_handle = HYD_pmcd_pmip_pmi_v1; - else - HYD_pmcd_pmip_pmi_handle = HYD_pmcd_pmip_pmi_v2; + if (hdr.pmi_version == 1) + HYD_pmcd_pmip_pmi_handle = HYD_pmcd_pmip_pmi_v1; + else + HYD_pmcd_pmip_pmi_handle = HYD_pmcd_pmip_pmi_v2; - HYDU_MALLOC(args, char **, MAX_PMI_ARGS * sizeof(char *), status); - for(i = 0;i < MAX_PMI_ARGS; i++) - args[i]= NULL; + HYDU_MALLOC(args, char **, MAX_PMI_ARGS * sizeof(char *), status); + for(i = 0;i < MAX_PMI_ARGS; i++) + args[i]= NULL; - status = HYD_pmcd_pmi_parse_pmi_cmd(buf, hdr.pmi_version, &pmi_cmd, args); - HYDU_ERR_POP(status, "unable to parse PMI command\n"); + status = HYD_pmcd_pmi_parse_pmi_cmd(buf, hdr.pmi_version, &pmi_cmd, args); + HYDU_ERR_POP(status, "unable to parse PMI command\n"); - if (HYD_pmcd_pmip.user_global.debug) { - HYDU_dump(stdout, "got pmi command (from %d): %s\n", fd, pmi_cmd); - HYDU_print_strlist(args); - } + if (HYD_pmcd_pmip.user_global.debug) { + HYDU_dump(stdout, "got pmi command (from %d): %s\n", fd, pmi_cmd); + HYDU_print_strlist(args); + } - h = HYD_pmcd_pmip_pmi_handle; - while (h->handler) { - if (!strcmp(pmi_cmd, h->cmd)) { - status = h->handler(fd, args); - HYDU_ERR_POP(status, "PMI handler returned error\n"); - goto fn_exit; - } - h++; + h = HYD_pmcd_pmip_pmi_handle; + while (h->handler) { + if (!strcmp(pmi_cmd, h->cmd)) { + status = h->handler(fd, args); + HYDU_ERR_POP(status, "PMI handler returned error\n"); + goto fn_exit; } + h++; + } - if (HYD_pmcd_pmip.user_global.debug) { - HYDU_dump(stdout, "we don't understand this command %s; forwarding upstream\n", - pmi_cmd); - } + if (HYD_pmcd_pmip.user_global.debug) { + HYDU_dump(stdout, "we don't understand this command %s; forwarding upstream\n", + pmi_cmd); + } - /* We don't understand the command; forward it upstream */ - hdr.cmd = PMI_CMD; - hdr.pid = fd; - hdr.buflen = strlen(buf); - status = - HYDU_sock_write(HYD_pmcd_pmip.upstream.control, &hdr, sizeof(hdr), &sent, &closed, - HYDU_SOCK_COMM_MSGWAIT); - HYDU_ERR_POP(status, "unable to send PMI header upstream\n"); - HYDU_ASSERT(!closed, status); + /* We don't understand the command; forward it upstream */ + hdr.cmd = PMI_CMD; + hdr.pid = fd; + hdr.buflen = strlen(buf); + status = + HYDU_sock_write(HYD_pmcd_pmip.upstream.control, &hdr, sizeof(hdr), &sent, &closed, + HYDU_SOCK_COMM_MSGWAIT); + HYDU_ERR_POP(status, "unable to send PMI header upstream\n"); + HYDU_ASSERT(!closed, status); - status = - HYDU_sock_write(HYD_pmcd_pmip.upstream.control, buf, hdr.buflen, &sent, &closed, - HYDU_SOCK_COMM_MSGWAIT); - HYDU_ERR_POP(status, "unable to send PMI command upstream\n"); - HYDU_ASSERT(!closed, status); + status = + HYDU_sock_write(HYD_pmcd_pmip.upstream.control, buf, hdr.buflen, &sent, &closed, + HYDU_SOCK_COMM_MSGWAIT); + HYDU_ERR_POP(status, "unable to send PMI command upstream\n"); + HYDU_ASSERT(!closed, status); - } while (repeat); + if (repeat) + /* there are more commands to process. */ + goto check_cmd; fn_exit: if (pmi_cmd) ----------------------------------------------------------------------- Summary of changes: src/pm/hydra/pm/pmiserv/pmip_cb.c | 119 +++++++++++++++++++------------------ test/mpi/spawn/spawn-rootargs.c | 2 +- test/mpi/spawn/testlist.in | 2 +- 3 files changed, 64 insertions(+), 59 deletions(-) hooks/post-receive -- MPICH primary repository

1 0

[mpich] MPICH primary repository branch, master, updated. v3.2-171-g14c326b
by noreply＠mpich.org 05 Feb '16

05 Feb '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "MPICH primary repository". The branch, master has been updated via 14c326b77674d7215fc32d809a21048ebfcded6f (commit) from 14f0484f8f1d5db44c81d26c9e366f6008aab40e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.mpich.org/mpich.git/commitdiff/14c326b77674d7215fc32d809a21048eb… commit 14c326b77674d7215fc32d809a21048ebfcded6f Author: Yanfei Guo <yguo(a)anl.gov> Date: Wed Dec 9 10:52:53 2015 -0600 Make string CVAR case-insensitive This patch fix ticket #2206. Currently, MPIR_CVAR_NEMESIS_NETMOD is case-insensitive while MPIR_CVAR_DEFAULT_THREAD_LEVEL is not. Replace strcmp with strcasecmp for MPIR_CVAR_DEFAULT_THREAD_LEVEL to make the comparison case-insensitive. Other CVAR of string type does not need to be case-insensitive as they are for path and interface names. Updating the description of case-insensitive CVARs. Signed-off-by: Pavan Balaji <balaji(a)anl.gov> diff --git a/src/mpi/init/init.c b/src/mpi/init/init.c index 5a43852..00ccf01 100644 --- a/src/mpi/init/init.c +++ b/src/mpi/init/init.c @@ -4,6 +4,8 @@ * See COPYRIGHT in top-level directory. */ +#include <strings.h> + #include "mpiimpl.h" #include "mpi_init.h" @@ -44,7 +46,8 @@ cvars: verbosity : MPI_T_VERBOSITY_USER_BASIC scope : MPI_T_SCOPE_ALL_EQ description : >- - Sets the default thread level to use when using MPI_INIT. + Sets the default thread level to use when using MPI_INIT. This variable + is case-insensitive. === END_MPI_T_CVAR_INFO_BLOCK === */ @@ -154,13 +157,13 @@ int MPI_Init( int *argc, char ***argv ) MPIR_T_env_init(); - if (!strcmp(MPIR_CVAR_DEFAULT_THREAD_LEVEL, "MPI_THREAD_MULTIPLE")) + if (!strcasecmp(MPIR_CVAR_DEFAULT_THREAD_LEVEL, "MPI_THREAD_MULTIPLE")) threadLevel = MPI_THREAD_MULTIPLE; - else if (!strcmp(MPIR_CVAR_DEFAULT_THREAD_LEVEL, "MPI_THREAD_SERIALIZED")) + else if (!strcasecmp(MPIR_CVAR_DEFAULT_THREAD_LEVEL, "MPI_THREAD_SERIALIZED")) threadLevel = MPI_THREAD_SERIALIZED; - else if (!strcmp(MPIR_CVAR_DEFAULT_THREAD_LEVEL, "MPI_THREAD_FUNNELED")) + else if (!strcasecmp(MPIR_CVAR_DEFAULT_THREAD_LEVEL, "MPI_THREAD_FUNNELED")) threadLevel = MPI_THREAD_FUNNELED; - else if (!strcmp(MPIR_CVAR_DEFAULT_THREAD_LEVEL, "MPI_THREAD_SINGLE")) + else if (!strcasecmp(MPIR_CVAR_DEFAULT_THREAD_LEVEL, "MPI_THREAD_SINGLE")) threadLevel = MPI_THREAD_SINGLE; else { MPL_error_printf("Unrecognized thread level %s\n", MPIR_CVAR_DEFAULT_THREAD_LEVEL); diff --git a/src/mpid/ch3/channels/nemesis/src/mpid_nem_network.c b/src/mpid/ch3/channels/nemesis/src/mpid_nem_network.c index 636ffa1..1f5cc31 100644 --- a/src/mpid/ch3/channels/nemesis/src/mpid_nem_network.c +++ b/src/mpid/ch3/channels/nemesis/src/mpid_nem_network.c @@ -22,7 +22,7 @@ cvars: scope : MPI_T_SCOPE_ALL_EQ description : >- If non-empty, this cvar specifies which network module - should be used for communication. + should be used for communication. This variable is case-insensitive. === END_MPI_T_CVAR_INFO_BLOCK === */ ----------------------------------------------------------------------- Summary of changes: src/mpi/init/init.c | 13 ++++++++----- .../ch3/channels/nemesis/src/mpid_nem_network.c | 2 +- 2 files changed, 9 insertions(+), 6 deletions(-) hooks/post-receive -- MPICH primary repository

1 0

[mpich] MPICH primary repository branch, master, updated. v3.2-170-g14f0484
by noreply＠mpich.org 03 Feb '16

03 Feb '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "MPICH primary repository". The branch, master has been updated via 14f0484f8f1d5db44c81d26c9e366f6008aab40e (commit) from ff06d55a59a379dd9cda9b152dacc80566eab785 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.mpich.org/mpich.git/commitdiff/14f0484f8f1d5db44c81d26c9e366f600… commit 14f0484f8f1d5db44c81d26c9e366f6008aab40e Author: Rob Latham <robl(a)mcs.anl.gov> Date: Thu Jan 14 12:56:14 2016 -0600 use libunwind only when both header and lib available libunwind has runtime libraries and compile-time heaers. Some systems might provide libunwind without the corresponding -dev package. Be more careful about when to choose libunwind. No Reviewer (but there was a lengty discussion on mpich-discuss) diff --git a/src/mpl/src/bt/mpl_bt.c b/src/mpl/src/bt/mpl_bt.c index 5abd999..ef10a59 100644 --- a/src/mpl/src/bt/mpl_bt.c +++ b/src/mpl/src/bt/mpl_bt.c @@ -44,7 +44,11 @@ static inline void backtrace_libback(FILE *output) btstate = backtrace_create_state(NULL, 1, NULL, NULL); backtrace_print(btstate, 0, output); } -#elif defined MPL_HAVE_LIBUNWIND +/* we need not only the symbols but the header file too (for the cursor and + * context), so tighten up when we take the libunwind path. Thanks + * Siegmar.Gross(a)informatik.hs-fulda.de for the bug report about systems with + * libunwind libraries but no libunwind development headers */ +#elif defined MPL_HAVE_LIBUNWIND && defined(MPL_HAVE_LIBUNWIND_H) static inline void backtrace_libunwind(FILE *output) { unw_cursor_t cursor; @@ -118,7 +122,7 @@ void MPL_backtrace_show(FILE *output) { #ifdef MPL_HAVE_LIBBACKTRACE backtrace_libback(output); -#elif defined MPL_HAVE_LIBUNWIND +#elif defined MPL_HAVE_LIBUNWIND && defined(MPL_HAVE_LIBUNWIND_H) /* libunwind is not able to get line numbers without forking off to * addr2line (?)*/ backtrace_libunwind(output); ----------------------------------------------------------------------- Summary of changes: src/mpl/src/bt/mpl_bt.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- MPICH primary repository

1 0

[mpich] MPICH primary repository branch, master, updated. v3.2-169-gff06d55
by noreply＠mpich.org 02 Feb '16

02 Feb '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "MPICH primary repository". The branch, master has been updated via ff06d55a59a379dd9cda9b152dacc80566eab785 (commit) from 78f4d6c6eb3db00281e524f22f8580e64abc97b7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.mpich.org/mpich.git/commitdiff/ff06d55a59a379dd9cda9b152dacc8056… commit ff06d55a59a379dd9cda9b152dacc80566eab785 Author: Ken Raffenetti <raffenet(a)mcs.anl.gov> Date: Mon Feb 1 09:19:38 2016 -0600 configure.ac: fixup help string Help string listed interlib-deps configure option without the "enable" prefix. No reviewer. diff --git a/configure.ac b/configure.ac index 7a561e0..ff936cf 100644 --- a/configure.ac +++ b/configure.ac @@ -403,7 +403,7 @@ AC_ARG_ENABLE(fast, ],,enable_fast=O2) AC_ARG_ENABLE(interlib-deps, - [AC_HELP_STRING([--interlib-deps - Enable interlibrary dependencies])],,enable_interlib_deps=yes) + [AC_HELP_STRING([--enable-interlib-deps - Enable interlibrary dependencies])],,enable_interlib_deps=yes) AC_ARG_ENABLE(check-compiler-flags, AC_HELP_STRING([--enable-check-compiler-flags], [enable the checks for all compiler ----------------------------------------------------------------------- Summary of changes: configure.ac | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- MPICH primary repository

1 0