Take a look at the makefile in the registry repo. It's not really a make thing, just an advantage of using templates.

PAGE_ARGS = --define kb_top=$(TARGET) --define kb_runtime=$(DEPLOY_RUNTIME) --define kb_service_name=$(SERVICE_NAME) --define kb_service_dir=$(SERVICE_DIR) --define kb_service_port=$(SERVICE_PORT)

deploy-service:
        mkdir -p $(TARGET)/services/$(SERVICE_DIR)
        $(TPAGE) $(TPAGE_ARGS) service/start_service.tt > $(TARGET)/services/$(SERVICE_DIR)/start_service
        chmod +x $(TARGET)/services/$(SERVICE_DIR)/start_service
        $(TPAGE) $(TPAGE_ARGS) service/stop_service.tt > $(TARGET)/services/$(SERVICE_DIR)/stop_service
        chmod +x $(TARGET)/services/$(SERVICE_DIR)/stop_service
        echo "done executing deploy-service target"


So what happens here is there is a template file called start_service.tt. TPAGE_ARGS get expanded in the template to become the start_service script. The benefit to this is that we can change the template and the change becomes somewhat globally implemented thought out the set of all services (that follow convention).

I don't mind working with you and doing some slight restructuring of your Makefile, if you want to schedule a time to work together.

t


On Jul 9, 2013, at 1:42 PM, Jason Baumohl <jkbaumohl@lbl.gov> wrote:

Hi Tom,

I do not pretend to be a make expert.  This project is the first time that I have used it.   Do you have an example of what you like me to change it to?

Thanks,
Jason


On Tue, Jul 9, 2013 at 6:34 AM, Thomas Brettin <brettint@gmail.com> wrote:
Hi Jason,

I was reviewing your module makefile, and I'd like to help you make some changes that will rely more on templates. Since your code is all perl, this should be pretty straight forward.

As an example, you have in your make file:

deploy-service-scripts: 
        # First create the start script (should be a better way to do this…)
…

Usually, we use tpage as a templating tool and use start_service.tt and stop_service.tt templates that get filled in at make time.

Also, I don't see a scripts directory. Do you have scripts that will be executable from IRIS?

Thanks,
Tom



On Jul 8, 2013, at 7:49 PM, Jason Baumohl <jkbaumohl@lbl.gov> wrote:

Works for me.

-Jason


On Mon, Jul 8, 2013 at 5:40 PM, Thomas Brettin <brettint@gmail.com> wrote:
I'd like to schedule this for a minor release and not wait until the Aug build. We'll do at least one minor release this month.


On Jul 1, 2013, at 5:06 PM, Jason Baumohl <jkbaumohl@lbl.gov> wrote:

> Hi Tom and Paramvir,
>
> I think I have an official candidate for release for expression.
>
> I have a bunch of stuff but includes the following:
> spec file
> impl code with 30 complete functions that have been tested (note 2 are currently incomplete functions - related to GEO parsing).
> automated testing for all completed functions
> readme
> releasenotes
> exchangeformat specs
> uploader
> preprocessors
> initial data loaded into expression on DB1
> automated doc for Impl code
> documentation for exchange format (file format for uploads).
>
> I think I have everything except scripts and commands to be run from the command line and iris.
>
> All of the code is committed to git.
>
> -Jason




_______________________________________________
Release-team mailing list
Release-team@lists.kbase.us
https://lists.kbase.us/mailman/listinfo/release-team