Re: [MPIWG Fortran] New Fortran errata Ticket #390
Dear Bill, thank you for your detailed review. I put all on the ticket. By the way, I changed now the [email protected] into [email protected] on the CC line (therefore the mail-rejection that you saw). Best regards Rolf ----- Original Message -----
From: "Bill Long" <[email protected]> To: "Rolf Rabenseifner" <[email protected]> Cc: "Craig Rasmussen" <[email protected]>, "Jeff Squyres" <[email protected]>, "MPI-3 Fortran working group" <[email protected]>, "Jeff Hammond" <[email protected]> Sent: Friday, August 23, 2013 6:15:31 PM Subject: Re: New Fortran errata Ticket #390 Hi Rolf,
I read through ticket and have these corrections:
1) In the first line of the Description, "lines 21-23" should be "lines 29-31".
2) In the last edit title, "lines 17-24" should be "lines 16-24". (for citation on page 411).
3) The existing text for the interfaces has a common problem - there is a use of the constant MPI_ADDRESS_KIND but this is not defined in the interface. Since these are all contained in either a module or header file where MPI_ADDRESS_KIND is defined, we only need a statement
IMPORT :: MPI_ADDRESS_KIND
8 times (twice for each replacement interface block, one for each subroutine). Within each interface block:
- In the first subroutine, the IMPORT statement should be inserted between the SUBROUTINE statement and the first INTEGER statement.
- In the second subroutine, the IMPORT statement should be inserted immediately after the USE statement.
You might want to include a paragraph at the beginning noting that this Errata also fixes the existing error in the text regarding the missing IMPORT statements.
I am planning to wait for these changes before adding comments directly to the ticket.
Cheers, Bill
On 8/22/13 3:10 AM, Rolf Rabenseifner wrote:
Dear Craig, Jeff S., and Bill L.,
I updated the ticket as discussed yesterday. Please, can you write your reviews as comments on the ticket.
Best regard, Rolf
----- Original Message -----
From: "Rolf Rabenseifner" <[email protected]> To: "Craig Rasmussen" <[email protected]>, "Jeff Squyres" <[email protected]>, "Bill Long" <[email protected]>, "Jeff Hammond" <[email protected]>, "Rolf Rabenseifner" <[email protected]> Cc: "MPI-3 Fortran working group" <[email protected]> Sent: Tuesday, August 20, 2013 11:01:53 AM Subject: New Fortran errata Ticket #390 Dear Craig, Jeff S., Bill, and Jeff H., (now with correct subject line: "Fortran")
I issued https://svn.mpi-forum.org/trac/mpi-forum-web/ticket/390 after a hint from Bill Long that our syntax was not really correct because always both specific interfaces should be put together into one generic interface.
As member of the binding chapter committee, please can you check the ticket and add a review to the ticket that we can - announce it 2 weeks before the meeting in Madrid, and - vote on it in Madrid.
Thanks and best regards Rolf
-- Bill Long [email protected] Fortran Technical Support & voice: 651-605-9024 Bioinformatics Software Development fax: 651-605-9142 Cray Inc./Cray Plaza, Suite 210/380 Jackson St./St. Paul, MN 55101
-- Dr. Rolf Rabenseifner . . . . . . . . . .. email [email protected] High Performance Computing Center (HLRS) . phone ++49(0)711/685-65530 University of Stuttgart . . . . . . . . .. fax ++49(0)711 / 685-65832 Head of Dpmt Parallel Computing . . . www.hlrs.de/people/rabenseifner Nobelstr. 19, D-70550 Stuttgart, Germany . . . . (Office: Room 1.307)
participants (1)
-
Rolf Rabenseifner