This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "MPICH primary repository". The branch, master has been updated via 7fdbaab175b2d5aecfa2e2ed5fbc80f901293454 (commit) from 4e03a16f9c9318b5a1ff0aed7be223ca4e5608e3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.mpich.org/mpich.git/commitdiff/7fdbaab175b2d5aecfa2e2ed5fbc80f901... commit 7fdbaab175b2d5aecfa2e2ed5fbc80f901293454 Author: Dave Goodell <[email protected]> Date: Mon Apr 8 23:03:27 2013 -0500 TAP: comply better with "TAP Version 13" The "TAP Version 13" specification (normally available at http://testanything.org/wiki/index.php/TAP_version_13_specification but currently only available via the Wayback Machine) does not actually permit spaces before a comment line. It also requires a special string at the beginning of the file to indicate that YAMLish should be expected. Otherwise, TAP::Parser will pretend not to see the YAML blocks. No reviewer. diff --git a/test/mpi/runtests.in b/test/mpi/runtests.in index 3dae546..dbe1f79 100644 --- a/test/mpi/runtests.in +++ b/test/mpi/runtests.in @@ -198,6 +198,7 @@ foreach $_ (@ARGV) { open( TAPOUT, ">$tapfile" ) || die "Cannot open $tapfile\n"; my $date = `date "+%Y-%m-%d-%H-%M"`; $date =~ s/\r?\n//; + print TAPOUT "TAP version 13\n"; print TAPOUT "# MPICH test suite results (TAP format)\n"; print TAPOUT "# date ${date}\n"; # we do not know at this point how many tests will be run, so do @@ -1039,12 +1040,14 @@ sub RunTestFailed { print TAPOUT " ...\n"; - # alternative to the "Output:" YAML block literal above - print TAPOUT " ## Test output (expected 'No Errors'):\n"; + # Alternative to the "Output:" YAML block literal above. Do not put any + # spaces before the '#', this causes some TAP parsers (including Perl's + # TAP::Parser) to treat the line as "unknown" instead of a proper + # comment. + print TAPOUT "## Test output (expected 'No Errors'):\n"; foreach my $line (split m/\r?\n/, $output) { chomp $line; - # 2 spaces for TAP indent - print TAPOUT " ## $line\n"; + print TAPOUT "## $line\n"; } } } ----------------------------------------------------------------------- Summary of changes: test/mpi/runtests.in | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-) hooks/post-receive -- MPICH primary repository