This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "MPICH primary repository". The branch, master has been updated via ed749773a9e4fd793c2f517a2029a29c61ed9526 (commit) from d2680c3c91a5508a934de4169960f8589740e235 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.mpich.org/mpich.git/commitdiff/ed749773a9e4fd793c2f517a2029a29c61... commit ed749773a9e4fd793c2f517a2029a29c61ed9526 Author: Ken Raffenetti <[email protected]> Date: Thu Jun 11 13:42:31 2015 -0500 answer FIXME in comment for MPIDI_CH3U_Recvq_FDU Signed-off-by: Halim Amer <[email protected]> diff --git a/src/mpid/ch3/src/ch3u_recvq.c b/src/mpid/ch3/src/ch3u_recvq.c index 8ac6d89..e6c2c56 100644 --- a/src/mpid/ch3/src/ch3u_recvq.c +++ b/src/mpid/ch3/src/ch3u_recvq.c @@ -318,8 +318,14 @@ MPID_Request * MPIDI_CH3U_Recvq_FDU(MPI_Request sreq_id, MPIR_TAG_CLEAR_ERROR_BITS(mask.parts.tag); /* Note that since this routine is used only in the case of send_cancel, - there can be only one match if at all. */ - /* FIXME: Why doesn't this exit after it finds the first match? */ + * there can be only one match, if at all. The reason the loop continues + * after finding a match is that send request handles are reused. In the + * case multiple requests with the same sender_req_id are present, only + * the last message is cancellable. This is because previous instances + * must have been tested or waited on the sender side, indicating completion + * and freeing the handle for reuse. Those completed operations cannot be + * cancelled. + */ cur_rreq = recvq_unexpected_head; while (cur_rreq != NULL) { MPIR_T_PVAR_TIMER_START(RECVQ, time_matching_unexpectedq); ----------------------------------------------------------------------- Summary of changes: src/mpid/ch3/src/ch3u_recvq.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) hooks/post-receive -- MPICH primary repository