This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "MPICH primary repository". The branch, master has been updated via 9adc7dde6262e02ce6e545e6a414949a88e234af (commit) via f546add3dd58a4a9c6c391e134c03c8a128f9188 (commit) from f6e68486df44e222a6f50ec2b513f4532aa7ea29 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.mpich.org/mpich.git/commitdiff/9adc7dde6262e02ce6e545e6a414949a88... commit 9adc7dde6262e02ce6e545e6a414949a88e234af Author: Rob Latham <[email protected]> Date: Wed Sep 2 16:39:26 2015 -0500 address "potentially used uninitialized" warnings No Reviewer diff --git a/src/mpi/romio/adio/ad_gpfs/ad_gpfs_rdcoll.c b/src/mpi/romio/adio/ad_gpfs/ad_gpfs_rdcoll.c index 910b51e..36f1f5c 100644 --- a/src/mpi/romio/adio/ad_gpfs/ad_gpfs_rdcoll.c +++ b/src/mpi/romio/adio/ad_gpfs/ad_gpfs_rdcoll.c @@ -175,7 +175,7 @@ void ADIOI_GPFS_ReadStridedColl(ADIO_File fd, void *buf, int count, st_offsets = (ADIO_Offset *) ADIOI_Malloc(nprocs*sizeof(ADIO_Offset)); end_offsets = (ADIO_Offset *) ADIOI_Malloc(nprocs*sizeof(ADIO_Offset)); - ADIO_Offset my_count_size; + ADIO_Offset my_count_size=0; /* One-sided aggregation needs the amount of data per rank as well because the difference in * starting and ending offsets for 1 byte is 0 the same as 0 bytes so it cannot be distiguished. */ diff --git a/src/mpi/romio/adio/ad_gpfs/ad_gpfs_wrcoll.c b/src/mpi/romio/adio/ad_gpfs/ad_gpfs_wrcoll.c index d3ba25d..3781a3c 100644 --- a/src/mpi/romio/adio/ad_gpfs/ad_gpfs_wrcoll.c +++ b/src/mpi/romio/adio/ad_gpfs/ad_gpfs_wrcoll.c @@ -176,7 +176,7 @@ void ADIOI_GPFS_WriteStridedColl(ADIO_File fd, const void *buf, int count, st_offsets = (ADIO_Offset *) ADIOI_Malloc(nprocs*sizeof(ADIO_Offset)); end_offsets = (ADIO_Offset *) ADIOI_Malloc(nprocs*sizeof(ADIO_Offset)); - ADIO_Offset my_count_size; + ADIO_Offset my_count_size=0; /* One-sided aggregation needs the amount of data per rank as well because * the difference in starting and ending offsets for 1 byte is 0 the same * as 0 bytes so it cannot be distiguished. diff --git a/src/mpi/romio/adio/common/onesided_aggregation.c b/src/mpi/romio/adio/common/onesided_aggregation.c index fedf9a0..db67cf5 100644 --- a/src/mpi/romio/adio/common/onesided_aggregation.c +++ b/src/mpi/romio/adio/common/onesided_aggregation.c @@ -855,11 +855,11 @@ printf("gpfsmpio_onesided_always_rmw - first buffer pre-read for file offsets %l /* These data structures are used for the derived datatype mpi_put * in the gpfsmpio_write_aggmethod of 2 case. */ - int *targetAggBlockLengths; - MPI_Aint *targetAggDisplacements, *sourceBufferDisplacements; - MPI_Datatype *targetAggDataTypes; + int *targetAggBlockLengths=NULL; + MPI_Aint *targetAggDisplacements=NULL, *sourceBufferDisplacements=NULL; + MPI_Datatype *targetAggDataTypes=NULL; - char *derivedTypePackedSourceBuffer; + char *derivedTypePackedSourceBuffer=NULL; int derivedTypePackedSourceBufferOffset = 0; int allocatedDerivedTypeArrays = 0; ADIO_Offset amountOfDataWrittenThisRoundAgg = 0; @@ -1957,9 +1957,9 @@ printf("iAmUsedAgg - currentRoundFDStart initialized " /* These data structures are used for the derived datatype mpi_get * in the gpfsmpio_read_aggmethod of 2 case. */ - int *sourceAggBlockLengths; - MPI_Aint *sourceAggDisplacements, *recvBufferDisplacements; - MPI_Datatype *sourceAggDataTypes; + int *sourceAggBlockLengths=NULL; + MPI_Aint *sourceAggDisplacements=NULL, *recvBufferDisplacements=NULL; + MPI_Datatype *sourceAggDataTypes=NULL; char *derivedTypePackedSourceBuffer; int derivedTypePackedSourceBufferOffset = 0; int allocatedDerivedTypeArrays = 0; http://git.mpich.org/mpich.git/commitdiff/f546add3dd58a4a9c6c391e134c03c8a12... commit f546add3dd58a4a9c6c391e134c03c8a128f9188 Author: Rob Latham <[email protected]> Date: Fri Aug 28 14:55:31 2015 -0500 error pointer left uninitialized in stub case when defining stub macros for the threadpackage-none case, one still needs to set the error pointer -- otherwise MPIR_Ext_thread_mutex_create will think the (dummy) creation failed. diff --git a/src/util/thread/mpiu_thread.h b/src/util/thread/mpiu_thread.h index cd96c3e..2a14446 100644 --- a/src/util/thread/mpiu_thread.h +++ b/src/util/thread/mpiu_thread.h @@ -39,8 +39,8 @@ typedef int MPIU_Thread_cond_t; typedef int MPIU_Thread_id_t; typedef int MPIU_Thread_tls_t; typedef void (*MPIU_Thread_func_t) (void *data); -#define MPIU_Thread_mutex_create(mutex_ptr_, err_ptr_) -#define MPIU_Thread_mutex_destroy(mutex_ptr_, err_ptr_) +#define MPIU_Thread_mutex_create(mutex_ptr_, err_ptr_) { *((int*)err_ptr_) = 0;} +#define MPIU_Thread_mutex_destroy(mutex_ptr_, err_ptr_) { *((int*)err_ptr_) = 0;} #else # error "thread package not defined or unknown" #endif ----------------------------------------------------------------------- Summary of changes: src/mpi/romio/adio/ad_gpfs/ad_gpfs_rdcoll.c | 2 +- src/mpi/romio/adio/ad_gpfs/ad_gpfs_wrcoll.c | 2 +- src/mpi/romio/adio/common/onesided_aggregation.c | 14 +++++++------- src/util/thread/mpiu_thread.h | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) hooks/post-receive -- MPICH primary repository