This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "MPICH primary repository". The branch, master has been updated via bce35b9f5993450c70913b6f58e24fcbb5bc90d0 (commit) via 33d82829042361809d36a7843a28e1bdeedf7110 (commit) from be21b8dbd448866fbbc3639c5703a488766b608a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.mpich.org/mpich.git/commitdiff/bce35b9f5993450c70913b6f58e24fcbb5... commit bce35b9f5993450c70913b6f58e24fcbb5bc90d0 Author: Ken Raffenetti <[email protected]> Date: Wed Jun 25 16:12:18 2014 -0500 add flag to enable C99 mode with Solaris compilers Autoconf maintains a comprehenive list of ways to enforce C99 mode with various compilers. http://git.savannah.gnu.org/cgit/autoconf.git/tree/lib/autoconf/c.m4 Since we regularly test with Sun/Solaris Studio, cherry pick the correct method to use with --enable-strict. Signed-off-by: Rob Latham <[email protected]> diff --git a/confdb/aclocal_cc.m4 b/confdb/aclocal_cc.m4 index 3ea2392..c706151 100644 --- a/confdb/aclocal_cc.m4 +++ b/confdb/aclocal_cc.m4 @@ -629,6 +629,10 @@ if test "$enable_strict_done" != "yes" ; then # enabled. If C99 is enabled, we automatically disable C89. if test "${enable_c99}" = "yes" ; then PAC_APPEND_FLAG([-std=c99],[pac_cc_strict_flags]) + # Use -D_STDC_C99= for Solaris compilers. See + # http://lists.gnu.org/archive/html/autoconf/2010-12/msg00059.html + # for discussion on why not to use -xc99 + PAC_APPEND_FLAG([-D_STDC_C99=],[pac_cc_strict_flags]) elif test "${enable_c89}" = "yes" ; then PAC_APPEND_FLAG([-std=c89],[pac_cc_strict_flags]) PAC_APPEND_FLAG([-Wdeclaration-after-statement],[pac_cc_strict_flags]) http://git.mpich.org/mpich.git/commitdiff/33d82829042361809d36a7843a28e1bdee... commit 33d82829042361809d36a7843a28e1bdeedf7110 Author: Ken Raffenetti <[email protected]> Date: Wed Jun 25 15:33:20 2014 -0500 increase feature level for pread/pwrite /usr/include/sys/feature_tests.h on Solaris says this about feature levels and C99: It is invalid to compile an XPG3, XPG4, XPG4v2, or XPG5 application using c99. The same is true for POSIX.1-1990, POSIX.2-1992, POSIX.1b, and POSIX.1c applications. Likewise, it is invalid to compile an XPG6 or a POSIX.1-2001 application with anything other than a c99 or later compiler. Therefore, we force an error in both cases. ROMIO builds would fail with --enable-strict because _XOPEN_SOURCE=500 was defined to expose pread/pwrite. Increasing the feature level to 600 makes usage strictly compatible with C99. Signed-off-by: Rob Latham <[email protected]> diff --git a/src/mpi/romio/adio/ad_lustre/ad_lustre_rwcontig.c b/src/mpi/romio/adio/ad_lustre/ad_lustre_rwcontig.c index fc4fd89..dbe2255 100644 --- a/src/mpi/romio/adio/ad_lustre/ad_lustre_rwcontig.c +++ b/src/mpi/romio/adio/ad_lustre/ad_lustre_rwcontig.c @@ -8,7 +8,7 @@ * Copyright (C) 2008 Sun Microsystems, Lustre group */ -#define _XOPEN_SOURCE 500 +#define _XOPEN_SOURCE 600 #include <unistd.h> #include <stdlib.h> diff --git a/src/mpi/romio/adio/ad_xfs/ad_xfs.h b/src/mpi/romio/adio/ad_xfs/ad_xfs.h index 048d156..cbddbbb 100644 --- a/src/mpi/romio/adio/ad_xfs/ad_xfs.h +++ b/src/mpi/romio/adio/ad_xfs/ad_xfs.h @@ -8,7 +8,7 @@ #ifndef AD_XFS_INCLUDE #define AD_XFS_INCLUDE -#define _XOPEN_SOURCE 500 +#define _XOPEN_SOURCE 600 #include <unistd.h> #include <sys/types.h> #include <fcntl.h> diff --git a/src/mpi/romio/adio/common/ad_read.c b/src/mpi/romio/adio/common/ad_read.c index 83510ba..dc0d773 100644 --- a/src/mpi/romio/adio/common/ad_read.c +++ b/src/mpi/romio/adio/common/ad_read.c @@ -6,7 +6,7 @@ */ -#define _XOPEN_SOURCE 500 +#define _XOPEN_SOURCE 600 #include <unistd.h> #include "adio.h" diff --git a/src/mpi/romio/adio/common/ad_write.c b/src/mpi/romio/adio/common/ad_write.c index 6a79f59..4a6c445 100644 --- a/src/mpi/romio/adio/common/ad_write.c +++ b/src/mpi/romio/adio/common/ad_write.c @@ -6,7 +6,7 @@ */ -#define _XOPEN_SOURCE 500 +#define _XOPEN_SOURCE 600 #include <unistd.h> #include "adio.h" ----------------------------------------------------------------------- Summary of changes: confdb/aclocal_cc.m4 | 4 ++++ src/mpi/romio/adio/ad_lustre/ad_lustre_rwcontig.c | 2 +- src/mpi/romio/adio/ad_xfs/ad_xfs.h | 2 +- src/mpi/romio/adio/common/ad_read.c | 2 +- src/mpi/romio/adio/common/ad_write.c | 2 +- 5 files changed, 8 insertions(+), 4 deletions(-) hooks/post-receive -- MPICH primary repository