This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "MPICH primary repository". The branch, master has been updated via 7b870da0cabc2e2c16e4fd6c5d7e84076886ca95 (commit) from 66b8196b05a515cb44ce7eb45d85cc5a9ccda1c9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.mpich.org/mpich.git/commitdiff/7b870da0cabc2e2c16e4fd6c5d7e840768... commit 7b870da0cabc2e2c16e4fd6c5d7e84076886ca95 Author: Pavan Balaji <[email protected]> Date: Tue Dec 3 11:53:38 2013 -0600 Check for number of arguments instead of a NULL argument. Thanks to Masamichi Takagi @ NEC, Japan for reporting the error and suggesting the patch. The cached PUTs array was not reinitialized to NULL values after the first time they were sent upstream and cleared. So the next time we push them upstream, they contained garbage data causing segfaults. This patch looks for the number of arguments rather than a NULL argument as a termination detector. Signed-off-by: Masamichi Takagi <[email protected]> diff --git a/src/pm/hydra/pm/pmiserv/pmip_pmi_v1.c b/src/pm/hydra/pm/pmiserv/pmip_pmi_v1.c index b46ab87..e36e047 100644 --- a/src/pm/hydra/pm/pmiserv/pmip_pmi_v1.c +++ b/src/pm/hydra/pm/pmiserv/pmip_pmi_v1.c @@ -46,7 +46,7 @@ static HYD_status send_cmd_upstream(const char *start, int fd, int num_args, cha j = 0; tmp[j++] = HYDU_strdup(start); - for (i = 0; args[i]; i++) { + for (i = 0; i < num_args; i++) { tmp[j++] = HYDU_strdup(args[i]); if (args[i + 1]) tmp[j++] = HYDU_strdup(" "); ----------------------------------------------------------------------- Summary of changes: src/pm/hydra/pm/pmiserv/pmip_pmi_v1.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- MPICH primary repository